Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soundness bug and refactor away unnecessary UnsafeCell. #290

Closed
wants to merge 1 commit into from

Conversation

BenBwall
Copy link

  • Fix a potential soundness bug by using ManuallyDrop.
  • Change SharedValue to contain a T instead of a UnsafeCell and remove as_ptr method.
  • Swap several calls to HashMap::get_key_value with calls to Hashmap::get_key_value_mut in order to make using UnsafeCell redundant.
  • Make unsafe blocks smaller and more refined.

- Fix a potential soundness bug by using ManuallyDrop.
- Change SharedValue to contain a T instead of a UnsafeCell<T> and remove as_ptr method.
- Swap several calls to `HashMap::get_key_value` with calls to `Hashmap::get_key_value_mut` in order to make using UnsafeCell redundant.
- Make unsafe blocks smaller and more refined.
@xacrimon
Copy link
Owner

xacrimon commented Feb 1, 2025

Fixed by another PR on master.

@xacrimon xacrimon closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants